Skip to content

V2: resolve a Wildcard UCC product when the wildcard is only in the SANs (EMS-1173) - #46

Merged
spbsoluble merged 2 commits into
fix/0098-cancelled-orders-stay-pendingfrom
fix/0099-wildcard-san-promotion
Nov 17, 2026
Merged

spbsoluble merged 2 commits into
fix/0098-cancelled-orders-stay-pendingfrom
fix/0099-wildcard-san-promotion

Conversation

@spbsoluble

@spbsoluble spbsoluble commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes EMS-1173 Invalid Additional Domain Names for a V2 DV or OV request whose CN is a plain name and whose SANs include a wildcard (CN example.com, SAN *.example.com).

Fixes

  • Why it failed:
    • CERTInext treats an order as wildcard only when certificate.domain starts with *..
    • The plugin sends the CN as the domain, so CERTInext picked a plain UCC product and rejected the wildcard.
    • Sending the wildcard as the domain doesn't work either: CERTInext requires the domain to match the CSR CN (EMS-1056).
  • What the plugin does now:
    • When the template has no ProductCode, it reads the catalog once.
    • It sends the account's one active Wildcard UCC product as X-Product-Code (type 21 for DV, 22 for OV).
    • The CN stays the domain.
  • When it fails instead: enrollment fails before placing an order, and asks for ProductCode, if there's no matching product, more than one, the catalog can't be read, or the order is EV.
  • Unchanged: an explicit ProductCode is used as before, with no lookup.

Testing

  • Unit tests: 8 new in V2ProductCodeResolutionTests; all 1358 pass.
  • Release build: 0 warnings.
  • Live probe: opt-in V2WildcardSanShapeTests (CERTINEXT_V2_WILDCARD_SAN_PROBE=1), plus a read-only catalog dump.

Other

spbsoluble and others added 2 commits November 16, 2026 20:02
…ildcard CN

A DV/OV request with CN = apex and SAN = *.apex failed with EMS-1173: the
wrapper keys "wildcard" on certificate.domain alone and resolved a plain
UCC product. Sending the wildcard as the domain is rejected too (EMS-1056,
the domain must match the CSR CN). Both confirmed live.

With no template ProductCode, the plugin now reads the catalog and sends
the account's single active Wildcard UCC product (typeID 21 DV / 22 OV) as
X-Product-Code. No match, several matches, a catalog failure, or EV fails
before any order is placed, asking for ProductCode.

Adds unit coverage and an opt-in live probe (CERTINEXT_V2_WILDCARD_SAN_PROBE).
@spbsoluble
spbsoluble added this pull request to stack #45 November 17, 2026 04:07
@spbsoluble
spbsoluble merged commit ceb2187 into release-2.0 Nov 17, 2026
@spbsoluble
spbsoluble deleted the fix/0099-wildcard-san-promotion branch November 17, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant